Greptile Summary

This PR adds a configMapMounts feature to the node-data-broker subchart, allowing users to declare ConfigMaps inline in values and have them automatically created and mounted into both the init container and the main container — primarily to supply extra config files (e.g. ibdiag.conf for ibnetdiscover).

• configmap-mounts.yaml — new template that renders one ConfigMap per configMapMounts[] entry using a |- block scalar for each data key; controlled by the same enabled guard as the DaemonSet.
• daemonset.yaml — volumeMounts and volumes sections extended to include the generated ConfigMaps in both init and main containers, keeping backward compatibility with the existing volumes/volumeMounts values fields.
• _helpers.tpl — two new helpers (configMapMountName, configMapMountVolumeName) derive K8s-safe names from the user-supplied name field; chart test coverage added in scripts/chart-test.sh.

Confidence Score: 5/5

Safe to merge — the missing ConfigMap template identified in the previous review is now present, the naming helpers are consistent between the ConfigMap and DaemonSet volume references, and all chart-test assertions should pass.

The configmap-mounts.yaml template correctly creates one ConfigMap per entry, the DaemonSet consistently references those ConfigMaps by the same generated names, the enabled guard is applied in both templates, and the chart test exercises the full rendering path including data content, mountPath, and subPath.

No files require special attention. The configmap-mounts.yaml data-block rendering uses a hand-rolled indent-4 approach rather than the more common nindent pattern, but it produces correct YAML for all documented use cases.

Important Files Changed

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[values.yaml\nconfigMapMounts list] --> B{enabled AND\nconfigMapMounts non-empty?}
    B -- Yes --> C[configmap-mounts.yaml\nrange over configMapMounts]
    C --> D[Render ConfigMap per entry\nname via configMapMountName helper\ndata keys rendered as block scalars]
    B -- No --> E[No ConfigMaps rendered]
    A --> F{daemonset.yaml\nenabled?}
    F -- Yes --> G[DaemonSet spec]
    G --> H{configMapMounts or\nvolumeMounts set?}
    H -- Yes --> I[volumeMounts in init container\nvolumeMounts in main container]
    H -- No --> J[No volumeMounts block]
    G --> K{configMapMounts or\nvolumes set?}
    K -- Yes --> L[Pod volumes\nconfigMap.name via configMapMountName\nvolumeName via configMapMountVolumeName]
    K -- No --> M[No volumes block]
    D -.->|names match| L

_{Reviews (2): Last reviewed commit: "feat(helm): add node-data-broker ConfigM..." | Re-trigger Greptile}

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.80%. Comparing base (1875ab8) to head (01ad8b6).
⚠️ Report is 68 commits behind head on main.

@@            Coverage Diff             @@
##             main     #347      +/-   ##
==========================================
+ Coverage   68.46%   70.80%   +2.33%     
==========================================
  Files          82       84       +2     
  Lines        4842     5031     +189     
==========================================
+ Hits         3315     3562     +247     
+ Misses       1395     1304      -91     
- Partials      132      165      +33     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🌿 Preview your docs: https://nvidia-preview-pull-request-347.docs.buildwithfern.com/topograph